Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Apply for new campaign flow #1432

Conversation

mm-hstefanova
Copy link
Contributor

@mm-hstefanova mm-hstefanova commented May 11, 2023

Code refactoring of the CampaignFilter component:

  • ListIconButtons - list of buttons with icons that can be reused for the CampaignFilter component and when we create a new campaign
  • Slightly CSS updates on the ListIconButtons - fixed the jumping issue on hover and made the hover line to be as big as the button's content

image
image
image

The approach for the Create Campaign Flow is to use the React context, this way:

  • we can store the data between the pages in one place
  • we can save the progress of creating a campaign to a specific step
  • we can change the stepper's active step from any Form component because of the context

Screenshots:

image
image

NOTE:

The new components have a prefix HS, for example, HSCreateForm, this is temporary, and the idea is to copy and modify the existing components. We still use them in the Admin panel, so it's not a good idea to modify them right away before we have a working flow.

@github-actions
Copy link

github-actions bot commented May 11, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev requested a review from ani-kalpachka May 22, 2023 06:09
@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label May 22, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label May 22, 2023
@ani-kalpachka
Copy link
Member

@mm-hstefanova great job!
Could you please check the lint errors?

@ani-kalpachka ani-kalpachka marked this pull request as draft May 31, 2023 16:11
Copy link
Member

@ani-kalpachka ani-kalpachka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in progress. Converting to a draft pr.

@ani-kalpachka ani-kalpachka marked this pull request as ready for review May 31, 2023 16:26
@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Jun 2, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jun 2, 2023
@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Jun 2, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jun 2, 2023
ani-kalpachka added 2 commits June 2, 2023 18:56
@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Jun 4, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jun 4, 2023
@sashko9807
Copy link
Member

Closing this for now.

@sashko9807 sashko9807 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants